Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with more Xcode instructions #40575

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

carlosmiceli
Copy link
Contributor

Details

Updated with instructions for Xcode that would have saved me a lot of time!

@carlosmiceli carlosmiceli self-assigned this Apr 19, 2024
@carlosmiceli carlosmiceli requested a review from a team as a code owner April 19, 2024 15:04
Copy link
Contributor

github-actions bot commented Apr 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from lakchote and removed request for a team April 19, 2024 15:05
Copy link

melvin-bot bot commented Apr 19, 2024

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@carlosmiceli
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@carlosmiceli carlosmiceli requested a review from blimpich April 23, 2024 21:02
@carlosmiceli
Copy link
Contributor Author

Hey @blimpich, GH suggested you as a reviewer so I figured I'd bring you in. I wanted to make a small improvement that would have helped me a lot to see in the Readme, but apparently the process here is different to get the PR approved. Did I do something wrong or should I do something different for this suggested change? Thanks in advance for your help!

@blimpich
Copy link
Contributor

Nope you didn't do anything wrong. If were just updating the readme this PR is good. The failing checks have to do with our automated checklists that we use for all Expensify/App PRs. If you look at other App PRs you'll notice each PR has a big long checklist that the author goes through to make sure that they've done their due diligence.

We're not changing any code here though so we're good to skip those checks 👍

@blimpich blimpich merged commit 1e38892 into main Apr 23, 2024
4 of 7 checks passed
@blimpich blimpich deleted the carlos-miceli-readme branch April 23, 2024 21:51
@melvin-bot melvin-bot bot added the Emergency label Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich
Copy link
Contributor

Not an emergency, just a README change

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.65-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@carlosmiceli
Copy link
Contributor Author

@blimpich Perrrfect, thanks for the explanation too!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants